Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]Extend notification related tests #6365

Merged
merged 1 commit into from
May 31, 2023
Merged

[tests-only][full-ci]Extend notification related tests #6365

merged 1 commit into from
May 31, 2023

Conversation

amrita-shrestha
Copy link
Contributor

Description

This PR adds tests for notification

  • Scenario Outline: user gets a notification of personal resource sharing in different languages
  • Scenario Outline: shared notification gets deleted when sharer deletes shared resource

Related Issue

Motivation and Context

How Has This Been Tested?

  • Locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@amrita-shrestha amrita-shrestha self-assigned this May 23, 2023
@amrita-shrestha amrita-shrestha force-pushed the extend-notification-api-tests branch from 437a7a8 to 93df6ed Compare May 23, 2023 06:18
@delete-merged-branch delete-merged-branch bot deleted the branch master May 24, 2023 07:11
@amrita-shrestha amrita-shrestha changed the base branch from extend-notification-api-tests to master May 24, 2023 08:57
@amrita-shrestha amrita-shrestha force-pushed the add-notifications-test branch 3 times, most recently from efaf26b to 1760240 Compare May 25, 2023 08:31
@amrita-shrestha amrita-shrestha marked this pull request as ready for review May 25, 2023 08:35
@amrita-shrestha amrita-shrestha force-pushed the add-notifications-test branch from 1760240 to d7495dd Compare May 30, 2023 03:54
@amrita-shrestha amrita-shrestha requested a review from saw-jan May 30, 2023 03:55
@ownclouders
Copy link
Contributor

ownclouders commented May 30, 2023 •
edited
Loading

E2E tests failed: https://drone.owncloud.com/owncloud/ocis/22792/89/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/ocis/22792/tracing/members-of-the-space-can-control-the-versions-of-the-files-alice-2023-5-30-11-16-49.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/ocis/22792/tracing/public-link-for-space-alice-2023-5-30-11-16-57.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/ocis/22792/tracing/public-link-for-space-brian-2023-5-30-11-17-19.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/ocis/22792/tracing/public-link-for-space-carol-2023-5-30-11-17-27.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/ocis/22792/tracing/public-link-for-space-david-2023-5-30-11-17-22.zip

@amrita-shrestha amrita-shrestha force-pushed the add-notifications-test branch from d7495dd to 08aff42 Compare May 30, 2023 09:12
@amrita-shrestha amrita-shrestha requested a review from SwikritiT May 30, 2023 09:13
@amrita-shrestha amrita-shrestha force-pushed the add-notifications-test branch from 08aff42 to e549da6 Compare May 31, 2023 03:53
@amrita-shrestha amrita-shrestha requested a review from saw-jan May 31, 2023 03:53
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

SagarGi
SagarGi reviewed May 31, 2023
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 if CI is green.

saw-jan
saw-jan reviewed May 31, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SwikritiT
SwikritiT approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amrita-shrestha amrita-shrestha merged commit 91ea910 into master May 31, 2023
@delete-merged-branch delete-merged-branch bot deleted the add-notifications-test branch May 31, 2023 10:15
2403905 pushed a commit to 2403905/ocis that referenced this pull request May 31, 2023
@amrita-shrestha @2403905
Extend notification tests scenario for different language (owncloud#6365
d10fe11 
)
fschade pushed a commit that referenced this pull request Jul 10, 2023
@amrita-shrestha @fschade
Extend notification tests scenario for different language (#6365)
7966c01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan left review comments

@SagarGi SagarGi SagarGi left review comments

@SwikritiT SwikritiT SwikritiT approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@ScharfViktor ScharfViktor Awaiting requested review from ScharfViktor

Assignees

@amrita-shrestha amrita-shrestha

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@amrita-shrestha @ownclouders @SwikritiT @SagarGi @saw-jan